[Go] add ResetKeep() and ResetBuffer() #8288
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function
ResetKeep()
which is likeReset()
except that it only re-uses the unused space left in the buffer: it keeps previous data which was in the buffer. This is useful if you want to allocate 1 large buffer and use it for a bunch of flatbuffer objects.With this change, both
Reset()
andResetKeep()
are now implemented in terms of a generalResetBuffer()
function which allows using an arbitrary given buffer.This also changes the behaviour of
growBytesBuffer
to never re-use the existing buffer: that would go against the meaning ofResetKeep()
. It was an unlikely code path anyway: it could happen only iflen(b.Bytes) < cap(b.Bytes)
which is only possible if the user manually setb.Bytes
.The code in
growBytesBuffer
was also simplified and optimized: the benchmark added in #8287 went fromto
on my personal laptop.